Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 3, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR introduces the useLinkProfile() hook for linking profiles to in-app and ecosystem accounts, enhances profile management, and updates various components and types across the codebase to support this functionality.

Detailed summary

  • Added useLinkProfile() hook for linking profiles.
  • Updated Profile type in types.ts.
  • Modified getUser() to include ecosystem.
  • Enhanced sidebar links for Ecosystem Wallets.
  • Added Profiles component to display linked profiles.
  • Updated UI components to incorporate new profile linking features.
  • Refactored existing code to accommodate the new linking functionality.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 8:15am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 8:15am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 8:15am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 8:15am

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2024

🦋 Changeset detected

Latest commit: d3dfb27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. packages labels Oct 3, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@joaquim-verges joaquim-verges changed the title feat: add useLinkProfile hook and update profile linking functionality feat: add useLinkProfile hook and update profile linking docs + playground Oct 3, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review October 3, 2024 09:38
@joaquim-verges joaquim-verges force-pushed the feat_add_useLinkProfile_hook_and_update_profile_linking_functionality branch 2 times, most recently from 7479f9c to 51bdbaf Compare October 3, 2024 09:43
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.96 KB (+0.03% 🔺) 840 ms (+0.03% 🔺) 360 ms (+106.38% 🔺) 1.2 s
thirdweb (cjs) 101.68 KB (+0.06% 🔺) 2.1 s (+0.06% 🔺) 431 ms (+14.37% 🔺) 2.5 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 66 ms (+331.41% 🔺) 162 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 53 ms (+215.19% 🔺) 63 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 97 ms (+150.44% 🔺) 441 ms

@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 47.61%. Comparing base (a94f981) to head (d3dfb27).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../thirdweb/src/wallets/in-app/core/users/getUser.ts 0.00% 2 Missing ⚠️
...irdweb/src/wallets/in-app/web/lib/web-connector.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4906      +/-   ##
==========================================
- Coverage   47.61%   47.61%   -0.01%     
==========================================
  Files        1057     1057              
  Lines       57221    57224       +3     
  Branches     3924     3924              
==========================================
+ Hits        27246    27247       +1     
- Misses      29286    29288       +2     
  Partials      689      689              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a94f981
packages 43.37% <40.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...hirdweb/src/react/web/hooks/wallets/useProfiles.ts 22.72% <ø> (ø)
...thirdweb/src/utils/any-evm/zksync/isZkSyncChain.ts 80.76% <100.00%> (+0.76%) ⬆️
.../thirdweb/src/wallets/in-app/web/lib/auth/index.ts 2.70% <ø> (ø)
...irdweb/src/wallets/in-app/web/lib/web-connector.ts 4.07% <0.00%> (-0.02%) ⬇️
.../thirdweb/src/wallets/in-app/core/users/getUser.ts 5.66% <0.00%> (-0.11%) ⬇️

@joaquim-verges joaquim-verges merged commit 63d0777 into main Oct 4, 2024
27 of 28 checks passed
@joaquim-verges joaquim-verges deleted the feat_add_useLinkProfile_hook_and_update_profile_linking_functionality branch October 4, 2024 08:18
@jnsdls jnsdls mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants